NihalJain commented on code in PR #7204:
URL: https://github.com/apache/hbase/pull/7204#discussion_r2262168435
##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/InfoServer.java:
##########
@@ -70,19 +73,16 @@ public InfoServer(String name, String bindAddress, int
port, boolean findPort,
// We are using the Hadoop HTTP server config properties.
// This makes it easy to keep in sync with Hadoop's UI servers, but hard
to set this
// separately for HBase.
- builder
- .keyPassword(HBaseConfiguration.getPassword(c,
"ssl.server.keystore.keypassword", null))
- .keyStore(c.get("ssl.server.keystore.location"),
- HBaseConfiguration.getPassword(c, "ssl.server.keystore.password",
null),
- c.get("ssl.server.keystore.type", "jks"))
- .trustStore(c.get("ssl.server.truststore.location"),
- HBaseConfiguration.getPassword(c, "ssl.server.truststore.password",
null),
- c.get("ssl.server.truststore.type", "jks"))
+ builder.keyPassword(getTLSPassword(c, "keystore.keypassword"))
+ .keyStore(getTLSProperty(c, "keystore.location"), getTLSPassword(c,
"keystore.password"),
Review Comment:
We could also con sider aligning these names based on other impls within
hbase for eg: rest and thrift uses `keystore.store`
https://github.com/apache/hbase/blob/master/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/Constants.java#L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
