chaijunjie0101 commented on code in PR #7117:
URL: https://github.com/apache/hbase/pull/7117#discussion_r2235874627
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java:
##########
@@ -253,6 +257,19 @@ private boolean tryComplete(LocateRequest req,
CompletableFuture<RegionLocations
default:
// Doing nothing
}
+
+ // The interval of invalidate meta cache task,
+ // if disable/delete table using same connection or usually create a new
connection, no need to
+ // set it.
+ // Suggest set it to 24h or a higher value, because disable/delete table
usually not very
+ // frequently.
+ long metaCacheInvalidateInterval = conn.getConfiguration()
+ .getLong("hbase.client.connection.metacache.invalidate-interval.ms", 0L);
+ if (metaCacheInvalidateInterval > 0) {
+ TimerTask invalidateMetaCacheTask =
getInvalidateMetaCacheTask(metaCacheInvalidateInterval);
+ AsyncConnectionImpl.RETRY_TIMER.newTimeout(invalidateMetaCacheTask,
Review Comment:
> Better pass this retryTimer in so it is a bit easier for us to write UTs.
pass it from AsyncRegionLocator, thanks for reviewing~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
