Apache9 commented on code in PR #7172:
URL: https://github.com/apache/hbase/pull/7172#discussion_r2232851516
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ScopeWALEntryFilter.java:
##########
@@ -39,13 +39,14 @@ public class ScopeWALEntryFilter implements WALEntryFilter,
WALCellFilter {
@Override
public Entry filter(Entry entry) {
- // Do not filter out an entire entry by replication scopes. As now we
support serial
- // replication, the sequence id of a marker is also needed by upper layer.
We will filter out
- // all the cells in the filterCell method below if the replication scopes
is null or empty.
+ NavigableMap<byte[], Integer> scopes =
entry.getKey().getReplicationScopes();
+ if (scopes == null || scopes.isEmpty()) {
+ return null;
Review Comment:
The old code is also want to solve the problem where we filter out an entire
Entry which causes serial replication to be stuck. Since now we will store the
necessary information before filtering, it is OK to restore the old logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
