NihalJain commented on code in PR #144:
URL: https://github.com/apache/hbase-thirdparty/pull/144#discussion_r2231819144


##########
dev-support/jenkins/Dockerfile:
##########
@@ -110,14 +112,60 @@ ENV MAVEN_HOME='/opt/maven'
 RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
     cat > /opt/maven/bin/mvn <<'EOF'
 #!/bin/bash
-TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
-if [ -f "$TOOLCHAIN" ]; then
+
+echo "Maven wrapper called with args: $@"

Review Comment:
   I think its good to keep the change as this improves logging and error 
handling. without this the out files were empty and swallowing errors making 
difficult to debug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to