mnpoonia commented on code in PR #7075:
URL: https://github.com/apache/hbase/pull/7075#discussion_r2224974542


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java:
##########
@@ -73,6 +80,16 @@ protected RecoveredEditsWriter 
createRecoveredEditsWriter(TableName tableName, b
     return new RecoveredEditsWriter(region, regionEditsPath, w, seqId);
   }
 
+  private String getWorkerNameComponent() {
+    if (walSplitter.rsServices == null) {
+      return "";
+    }
+    return URLEncoder.encode(
+      walSplitter.rsServices.getServerName().toShortString()

Review Comment:
   I think there is a filename length limit of 255 in HDFS by default
   
https://github.com/naver/hadoop/blob/master/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java#L373
   
   But of course i am no expert and new to that code path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to