NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216997781


##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
   <artifactId>hbase-shaded-protobuf</artifactId>
   <name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
   <description>Pulls down protobuf, patches it, compiles, and then 
relocates/shades.</description>
+  <properties>
+    <!-- Override parent's JDK 17 settings to force JDK 8 for 
hbase-shaded-protobuf.

Review Comment:
   IMPORTANT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to