taklwu commented on code in PR #7150:
URL: https://github.com/apache/hbase/pull/7150#discussion_r2201472479
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreConstants.java:
##########
@@ -116,6 +116,12 @@ public interface BackupRestoreConstants {
"Specifies a custom backup location for Point-In-Time Recovery (PITR). "
+ "If provided, this location will be used exclusively instead of
deriving the path from the system table.";
+ String OPTION_FORCE_RESTORE = "f";
+ String LONG_OPTION_FORCE_RESTORE = "force";
+ String OPTION_FORCE_RESTORE_DESC =
Review Comment:
nit: can you explain why should we support this use case if missing backup
could cause data loss ?
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/PointInTimeRestoreDriver.java:
##########
@@ -69,6 +72,12 @@ protected int executeRestore(boolean check, TableName[]
fromTables, TableName[]
return -1;
}
+ boolean force = cmd.hasOption(OPTION_FORCE_RESTORE);
+ if (force) {
+ LOG.debug("Found force option (-{}) in restore command, "
Review Comment:
or maybe WARN level?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java:
##########
@@ -1195,6 +1195,11 @@ public int run(String[] args) throws Exception {
public static void main(String[] args) throws Exception {
Configuration conf = HBaseConfiguration.create();
int ret = ToolRunner.run(conf, new BulkLoadHFilesTool(conf), args);
+ if (ret == 0) {
+ System.out.println("Bulk load completed successfully.");
+ System.out.println("IMPORTANT: Please take a backup of the table
immediately if this table "
Review Comment:
this is not related, you can ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
