Apache9 commented on code in PR #7075:
URL: https://github.com/apache/hbase/pull/7075#discussion_r2190135183
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitUtil.java:
##########
@@ -193,7 +195,8 @@ static Path getRegionSplitEditsPath(TableName tableName,
byte[] encodedRegionNam
// Append file name ends with RECOVERED_LOG_TMPFILE_SUFFIX to ensure
// region's replayRecoveredEdits will not delete it
String fileName = formatRecoveredEditsFileName(seqId);
- fileName = getTmpRecoveredEditsFileName(fileName + "-" +
fileNameBeingSplit);
+ fileName =
Review Comment:
OK, so here we still use the same directory, just different file names.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java:
##########
@@ -73,6 +80,16 @@ protected RecoveredEditsWriter
createRecoveredEditsWriter(TableName tableName, b
return new RecoveredEditsWriter(region, regionEditsPath, w, seqId);
}
+ private String getWorkerNameComponent() {
+ if (walSplitter.rsServices == null) {
+ return "";
+ }
+ return URLEncoder.encode(
+ walSplitter.rsServices.getServerName().toShortString()
Review Comment:
Why not just use ServerName.getServerName? In this way we do not need to
replace the ':'? And It seems that when creating WAL directories, we do not use
URLEncoder...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
