Apache9 commented on code in PR #6947:
URL: https://github.com/apache/hbase/pull/6947#discussion_r2185591302
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapred/TableSnapshotInputFormat.java:
##########
@@ -56,6 +56,7 @@ public
TableSnapshotRegionSplit(TableSnapshotInputFormatImpl.InputSplit delegate
this.delegate = delegate;
}
+ @Deprecated
Review Comment:
Please add javadoc and deprecated tag to specify the life cycle for these
APIs. You can find some examples in the current code base. And please also add
some docs to explain why it is deprecated.
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java:
##########
@@ -145,13 +146,19 @@ public static class InputSplit implements Writable {
private String[] locations;
private String scan;
private String restoreDir;
+ private long length;
// constructor for mapreduce framework / Writable
public InputSplit() {
}
public InputSplit(TableDescriptor htd, RegionInfo regionInfo, List<String>
locations, Scan scan,
Path restoreDir) {
+ this(htd, regionInfo, locations, scan, restoreDir, 1);
Review Comment:
Are there any difficulties removing this constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
