junegunn commented on code in PR #7076:
URL: https://github.com/apache/hbase/pull/7076#discussion_r2134536849
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java:
##########
@@ -72,6 +72,7 @@ public void
testAutoTunerShouldBeOffWhenMaxMinRangesForMemstoreIsNotGiven() thro
conf.setFloat(MemorySizeUtil.MEMSTORE_SIZE_KEY, 0.02f);
conf.setFloat(HeapMemoryManager.BLOCK_CACHE_SIZE_MAX_RANGE_KEY, 0.75f);
conf.setFloat(HeapMemoryManager.BLOCK_CACHE_SIZE_MIN_RANGE_KEY, 0.03f);
+ conf.setFloat(HConstants.HBASE_REGION_SERVER_FREE_HEAP_MIN_SIZE_KEY, 0.2f);
Review Comment:
So we have reverted the default. Do we still need this `setFloat`s?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java:
##########
@@ -72,6 +72,7 @@ public void
testAutoTunerShouldBeOffWhenMaxMinRangesForMemstoreIsNotGiven() thro
conf.setFloat(MemorySizeUtil.MEMSTORE_SIZE_KEY, 0.02f);
conf.setFloat(HeapMemoryManager.BLOCK_CACHE_SIZE_MAX_RANGE_KEY, 0.75f);
conf.setFloat(HeapMemoryManager.BLOCK_CACHE_SIZE_MIN_RANGE_KEY, 0.03f);
+ conf.setFloat(HConstants.HBASE_REGION_SERVER_FREE_HEAP_MIN_SIZE_KEY, 0.2f);
Review Comment:
So we have reverted the default. Do we still need these `setFloat`s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
