ndimiduk commented on PR #6868: URL: https://github.com/apache/hbase/pull/6868#issuecomment-2943189205
Yes, I agree that slightly different changes will be needed for each release line branch. I still have concerns about removing the `final` modifier from those existing fields for 2.6.x and 2.5.x. I am curious to see how our API compatibility checker reports such a change. If it passes the checker then I rescind my objections for the active 2.x release lines, I'll settle for an addition to the release notes. However, if that change is considered as API- or ABI-incompatible, you'll need to make further adjustments. What if, for example, instead of altering the existing fields, you collect the per-region values in their own accumulators, and update the existing scan-level field values on each transition. That way the existing references stay as final and existing access patterns remain valid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
