junegunn commented on code in PR #7052:
URL: https://github.com/apache/hbase/pull/7052#discussion_r2119731908
##########
hbase-diagnostics/src/test/java/org/apache/hadoop/hbase/TestPerformanceEvaluation.java:
##########
@@ -403,4 +404,30 @@ boolean testRow(long i, long startTime) throws
IOException, InterruptedException
return false;
}
}
+
+ @Test
+ public void testParseBooleanFlags() {
+ final Queue<String> opts = new LinkedList<>();
+ opts.offer("--valueRandom");
+ opts.offer("--autoFlush"); // default: false
+ opts.offer("--inmemory=true"); // default: false
+ opts.offer("--writeToWAL=false"); // default: true
+ opts.offer(PerformanceEvaluation.RANDOM_READ);
+ opts.offer("1");
+
+ final PerformanceEvaluation.TestOptions options =
PerformanceEvaluation.parseOpts(opts);
+ assertTrue(options.valueRandom);
+ assertTrue(options.flushCommits);
Review Comment:
Good bot :)
Addressed in 32a73ec96c5d1c99b153694c3dcb1202b0952804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
