stoty commented on PR #6999: URL: https://github.com/apache/hbase/pull/6999#issuecomment-2919078864
> I wonder if we should rather remove JSON deserialisation for BucketCache. Or at least put some safeguards that check for the size of the BucketCache object. Yes, it's completely bonkers. On closer look, [HBASE-29362](https://issues.apache.org/jira/browse/HBASE-29362) is not using the BucketCache object itself, so it's not really realted to this issue. I totally agree that we should just remove all code that tries to use Gson to serialize complext multigigabyte in-memory cache objects with reflection. TBH Gson itself looks like a spectaculrarly bad fit with modular JAva, and real objects. Maybe it's OK for simle POJO DTOs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
