kgeisz commented on code in PR #6931:
URL: https://github.com/apache/hbase/pull/6931#discussion_r2110168445
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##########
@@ -609,6 +609,12 @@ protected String getUseThisHostnameInstead(Configuration
conf) {
private void registerConfigurationObservers() {
configurationManager.registerObserver(this.rpcServices);
configurationManager.registerObserver(this);
+ if (cpHost != null) {
Review Comment:
I don't think that is needed because the Master stays alive throughout the
duration of the process. I can't think of a scenario where the observers need
to be deregistered while Master is still alive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
