[ 
https://issues.apache.org/jira/browse/HBASE-29349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953712#comment-17953712
 ] 

Nick Dimiduk commented on HBASE-29349:
--------------------------------------

I think that we can continue using deprecated attribute names on 2.6, emit both 
names on 2.7 and 3.0, and drop the deprecated names for 2.8+/3.1+/4.0+.

What do you think?

> Upgrade to opentelemetry-semconv 1.32.0
> ---------------------------------------
>
>                 Key: HBASE-29349
>                 URL: https://issues.apache.org/jira/browse/HBASE-29349
>             Project: HBase
>          Issue Type: Task
>          Components: tracing
>            Reporter: Nihal Jain
>            Assignee: Nihal Jain
>            Priority: Major
>              Labels: pull-request-available
>
> We moved to opentelemetry latest packages with 
> [HBASE-29349](https://issues.apache.org/jira/browse/HBASE-29349)  but 
> deliberately chose to not jump to latest for semconv as it introduces few 
> deprecations, which if removed can cause incompatibilities. With this task we 
> want to see best approach to move to latest semconv and how to deal with 
> these deprecations.
> [SemanticAttributes.java](https://github.com/open-telemetry/semantic-conventions-java/blob/v1.29.0/semconv/src/main/java/io/opentelemetry/semconv/SemanticAttributes.java)
>  has been removed and broken down into following with 
> [semantic-conventions-java#v1.30.0-rc.1](https://github.com/open-telemetry/semantic-conventions-java/releases/tag/v1.30.0-rc.1)
> - 
> [DbIncubatingAttributes.java](https://github.com/open-telemetry/semantic-conventions-java/blob/v1.32.0/semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/DbIncubatingAttributes.java)
> - 
> [RpcIncubatingAttributes.java](https://github.com/open-telemetry/semantic-conventions-java/blob/v1.32.0/semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/RpcIncubatingAttributes.java)
> - 
> [NetIncubatingAttributes.java](https://github.com/open-telemetry/semantic-conventions-java/blob/v1.32.0/semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/NetIncubatingAttributes.java)
> - 
> [ExceptionAttributes.java](https://github.com/open-telemetry/semantic-conventions-java/blob/v1.32.0/semconv/src/main/java/io/opentelemetry/semconv/ExceptionAttributes.java)
> - and so on
> Also there has been a few deprecations, for example refer 
> [db-migration.md](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/db-migration.md)
> - `db.system` has been deprecated and renamed to `db.system.name`
> - `db.operation` has been deprecated and renamed to `db.operation.name`
> - and so on
> But with first draft of this change we continue to use the deprecated names. 
> If we decide on following the migration guide we can remove and handle the 
> change as suggested in the guide or simply change them and break the 
> compatibility.
> Docs:
> - https://github.com/open-telemetry/semantic-conventions/tree/main/docs
> - 
> https://github.com/open-telemetry/semantic-conventions/tree/main/docs/non-normative
> CC: [~ndimiduk]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to