[
https://issues.apache.org/jira/browse/HBASE-29293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953449#comment-17953449
]
Nihal Jain edited comment on HBASE-29293 at 5/22/25 1:36 PM:
-------------------------------------------------------------
{quote}[~nihaljain.cs] this one should be safe to backport to active release
line, or do we stop at branch-2?
{quote}
Raised [https://github.com/apache/hbase/pull/7017] for branch-2.6
# Built hbase with this change locally, exported following:
**
{code:java}
export HBASE_OTEL_TRACING_ENABLED=true
export OTEL_TRACES_EXPORTER=logging
export OTEL_METRICS_EXPORTER=none
{code}
# Started in standalone mode and started shell, ran few ops.
# Repeated above steps with hbase-2.6.2 release
Resultant client logs
* [^telemetry-2.6.3-SNAPSHOT.txt]
* [^telemetry-2.6.2.txt]
Skimmed through them AttributesMap look alike.
Also comapre binaries, they seem alike.
* !Screenshot 2025-05-22 at 6.50.57 PM.png!
* !Screenshot 2025-05-22 at 6.51.18 PM.png!
Only that not sure why we are bundling these jars twice in branch-2. Once in
lib and then in client-facing-thirdparty. Will fix this with another JIRA!
Based on above steps I think we should be good to pull them in branch-2.6. I
hope these steps are good enough to validate regression. Should I do anything
more?
Also [~apurtell] should I pull this in branch-2.5 as well?
was (Author: nihaljain.cs):
{quote}[~nihaljain.cs] this one should be safe to backport to active release
line, or do we stop at branch-2?
{quote}
Created [https://github.com/apache/hbase/pull/7017] for branch-2.6
# Built hbase with this change locally, exported following:
**
{code:java}
export HBASE_OTEL_TRACING_ENABLED=true
export OTEL_TRACES_EXPORTER=logging
export OTEL_METRICS_EXPORTER=none
{code}
# Started in standalone mode and started shell, ran few ops.
# Repeated above steps with hbase-2.6.2 release
Resultant client logs
* [^telemetry-2.6.3-SNAPSHOT.txt]
* [^telemetry-2.6.2.txt]
Skimmed through them AttributesMap look alike.
Also comapre binaries, they seem alike.
* !Screenshot 2025-05-22 at 6.50.57 PM.png!
* !Screenshot 2025-05-22 at 6.51.18 PM.png!
Only that not sure why we are bundling these jars twice in branch-2. Once in
lib and then in client-facing-thirdparty. Will fix this with another JIRA!
Based on above steps I think we should be good to pull them in branch-2.6. I
hope these steps are good enough to validate regression. Should I do anything
more?
Also [~apurtell] should I pull this in branch-2.5 as well?
> Upgrade to latest opentelemetry libraries
> -----------------------------------------
>
> Key: HBASE-29293
> URL: https://issues.apache.org/jira/browse/HBASE-29293
> Project: HBase
> Issue Type: Task
> Components: tracing
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Major
> Labels: pull-request-available
> Attachments: Screenshot 2025-05-22 at 6.50.57 PM.png, Screenshot
> 2025-05-22 at 6.51.18 PM.png, telemetry-2.6.2.txt,
> telemetry-2.6.3-SNAPSHOT.txt
>
>
> We are using pretty old opentelemetry packages which were released almost 3
> years ago. Maybe it's good for us to move to latest ones.
> Also, now we can move to a non-alpha semconv although it might introduce some
> incompatibilities in naming conventions. I am not targeting non-alpha with
> this change, we can do it as another commit, so that we can backport this one
> to all active branches.
> CC: [~ndimiduk]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
