NihalJain commented on code in PR #7016:
URL: https://github.com/apache/hbase/pull/7016#discussion_r2102338319
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseSemanticAttributes.java:
##########
@@ -46,20 +49,20 @@ public final class HBaseSemanticAttributes {
AttributeKey.stringArrayKey("db.hbase.container_operations");
public static final AttributeKey<List<String>> REGION_NAMES_KEY =
AttributeKey.stringArrayKey("db.hbase.regions");
- public static final AttributeKey<String> RPC_SYSTEM =
SemanticAttributes.RPC_SYSTEM;
- public static final AttributeKey<String> RPC_SERVICE =
SemanticAttributes.RPC_SERVICE;
- public static final AttributeKey<String> RPC_METHOD =
SemanticAttributes.RPC_METHOD;
+ public static final AttributeKey<String> RPC_SYSTEM =
RpcIncubatingAttributes.RPC_SYSTEM;
+ public static final AttributeKey<String> RPC_SERVICE =
RpcIncubatingAttributes.RPC_SERVICE;
+ public static final AttributeKey<String> RPC_METHOD =
RpcIncubatingAttributes.RPC_METHOD;
public static final AttributeKey<String> SERVER_NAME_KEY =
AttributeKey.stringKey("db.hbase.server.name");
- public static final AttributeKey<String> NET_PEER_NAME =
SemanticAttributes.NET_PEER_NAME;
- public static final AttributeKey<Long> NET_PEER_PORT =
SemanticAttributes.NET_PEER_PORT;
+ public static final AttributeKey<String> NET_PEER_NAME =
NetIncubatingAttributes.NET_PEER_NAME;
+ public static final AttributeKey<Long> NET_PEER_PORT =
NetIncubatingAttributes.NET_PEER_PORT;
public static final AttributeKey<Boolean> ROW_LOCK_READ_LOCK_KEY =
AttributeKey.booleanKey("db.hbase.rowlock.readlock");
public static final AttributeKey<String> WAL_IMPL =
AttributeKey.stringKey("db.hbase.wal.impl");
- public static final AttributeKey<String> EXCEPTION_TYPE =
SemanticAttributes.EXCEPTION_TYPE;
- public static final AttributeKey<String> EXCEPTION_MESSAGE =
SemanticAttributes.EXCEPTION_MESSAGE;
- public static final String EXCEPTION_EVENT_NAME =
SemanticAttributes.EXCEPTION_EVENT_NAME;
+ public static final AttributeKey<String> EXCEPTION_TYPE =
ExceptionAttributes.EXCEPTION_TYPE;
+ public static final AttributeKey<String> EXCEPTION_MESSAGE =
ExceptionAttributes.EXCEPTION_MESSAGE;
+ public static final String EXCEPTION_EVENT_NAME = "exception";
Review Comment:
This key has been removed with no replacement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
