Apache9 commented on code in PR #6974:
URL: https://github.com/apache/hbase/pull/6974#discussion_r2101494002
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java:
##########
@@ -514,18 +514,23 @@ private void open() throws IOException {
comparator = initialReader.getComparator();
}
+ public void initReader() throws IOException {
+ initReader(false);
+ }
+
/**
* Initialize the reader used for pread.
*/
- public void initReader() throws IOException {
- if (initialReader == null) {
+ public void initReader(boolean reopen) throws IOException {
+ if (initialReader == null || reopen) {
synchronized (this) {
- if (initialReader == null) {
+ if (initialReader == null || reopen) {
+ boolean evictOnClose = cacheConf == null ||
cacheConf.shouldEvictOnClose();
try {
+ if (reopen) closeStoreFile(evictOnClose);
Review Comment:
OK, we use evictOnClose here too.
Please use change to
```
if () {
}
```
To avoid a checkstyle warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
