sanjeet006py commented on code in PR #6868:
URL: https://github.com/apache/hbase/pull/6868#discussion_r2096136172
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/metrics/ScanMetrics.java:
##########
@@ -51,53 +51,118 @@ public class ScanMetrics extends ServerSideScanMetrics {
/**
* number of RPC calls
*/
- public final AtomicLong countOfRPCcalls =
createCounter(RPC_CALLS_METRIC_NAME);
+ @SuppressWarnings("checkstyle:VisibilityModifier")
Review Comment:
@ndimiduk w/o suppressing checkstyle warnings these get flagged. I agree
that having these fields as public itself is not right and with changing them
to non-final it has become worse but in order to roll the metrics `AtomicLong`
instances I had to do it this way. I would happy to create a separate JIRA for
cleaning up exposing metrics as public fields directly but I think for HBase 3
(maybe) and for HBase 2 we can't clean this up w/o breaking backward
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
