d-c-manning commented on code in PR #6994: URL: https://github.com/apache/hbase/pull/6994#discussion_r2093779317
########## hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java: ########## @@ -2558,6 +2558,7 @@ public ClearDeadServersResponse clearDeadServers(RpcController controller, } @Override + @QosPriority(priority = HConstants.HIGH_QOS) Review Comment: why `HIGH_QOS` vs. `ADMIN_QOS`? Are they in conflict with each other? Does `HIGH_QOS` do something here that `ADMIN_QOS` does not? No other methods in this class use `HIGH_QOS`. And it seems `SimpleRpcScheduler` doesn't distinguish between the two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
