Apache9 commented on code in PR #6983:
URL: https://github.com/apache/hbase/pull/6983#discussion_r2086989879
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java:
##########
@@ -2483,7 +2487,21 @@ private void processAssignmentPlans(final
HashMap<RegionInfo, RegionStateNode> r
acceptPlan(regions, balancer.retainAssignment(retainMap, servers));
} catch (HBaseIOException e) {
LOG.warn("unable to retain assignment", e);
- addToPendingAssignment(regions, retainMap.keySet());
+
+ for(RegionInfo hri : retainMap.keySet()) {
+ int retryCount = retryCountMap.getOrDefault(hri,0) + 1;
+ retryCountMap.put(hri, retryCount);
+
+ if(retryCount > MAX_RETRY_LIMIT) {
Review Comment:
Better add a backoff here? If we go with this PR, the region will be in RIT
state forever and only restarting master can trigger the reassign...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
