kgeisz commented on code in PR #6931:
URL: https://github.com/apache/hbase/pull/6931#discussion_r2059408863
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ReadOnlyController.java:
##########
@@ -65,26 +66,25 @@
@CoreCoprocessor
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
-public class ReadOnlyController
- implements MasterCoprocessor, RegionCoprocessor, MasterObserver,
RegionObserver,
- RegionServerCoprocessor, RegionServerObserver, EndpointObserver,
BulkLoadObserver {
+public class ReadOnlyController implements MasterCoprocessor,
RegionCoprocessor, MasterObserver,
+ RegionObserver, RegionServerCoprocessor, RegionServerObserver,
EndpointObserver, BulkLoadObserver,
+ ConfigurationObserver {
private static final Logger LOG =
LoggerFactory.getLogger(ReadOnlyController.class);
- private Configuration conf;
+ private volatile boolean globalReadOnlyEnabled;
Review Comment:
I know we talked about this in our meeting. I will add a comment here as
well for completeness. I chose to use `volatile` because that is consistent
with what I have seen in other PRs for dynamic configuration. The PRs I looked
at were https://github.com/apache/hbase/pull/5823 and
https://github.com/apache/hbase/pull/4181.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
