charlesconnell commented on code in PR #6857:
URL: https://github.com/apache/hbase/pull/6857#discussion_r2048797619
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/DictionaryCache.java:
##########
@@ -91,7 +91,7 @@ public byte[] load(String s) throws Exception {
try {
return CACHE.get(path);
} catch (ExecutionException e) {
- throw new IOException(e);
+ throw new RuntimeException("Unable to load dictionary at " + path, e);
Review Comment:
I did this to be more consistent with ZstdCodec line 153. At some point in
the stack we need to swallow a checked exception or make it unchecked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
