DieterDP-ng commented on code in PR #6506:
URL: https://github.com/apache/hbase/pull/6506#discussion_r2048557780
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##########
@@ -146,13 +146,17 @@ public static void
decorateRegionServerConfiguration(Configuration conf) {
classes + "," + regionProcedureClass);
}
String coproc = conf.get(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY);
- String regionObserverClass = BackupObserver.class.getName();
+ String observerClass = BackupObserver.class.getName();
conf.set(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY,
- (coproc == null ? "" : coproc + ",") + regionObserverClass);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Added region procedure manager: {}. Added region observer:
{}",
- regionProcedureClass, regionObserverClass);
- }
+ (coproc == null ? "" : coproc + ",") + observerClass);
+
+ String masterCoProc =
conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY);
Review Comment:
Updated!
I also extracted all master-related stuff from the `BackupObserver` to
`BackupMasterObserver`. Did this in the light of HBASE-29240, where there's
more master-specific logic being added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
