Reidddddd commented on code in PR #6874:
URL: https://github.com/apache/hbase/pull/6874#discussion_r2038864010
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java:
##########
@@ -328,6 +333,13 @@ private void copyFile(final Context context, final
SnapshotFileInfo inputInfo,
// Ensure that the output folder is there and copy the file
createOutputPath(outputPath.getParent());
+ String family = new Path(inputInfo.getHfile()).getParent().getName();
+ String familyStoragePolicy = generateFamilyStoragePolicyKey(family);
+ if
(stringIsNotEmpty(context.getConfiguration().get(familyStoragePolicy))) {
+ String key = context.getConfiguration().get(familyStoragePolicy);
+ LOG.info("Setting storage policy {} for {}", key,
outputPath.getParent());
+ outputFs.setStoragePolicy(outputPath.getParent(), key);
Review Comment:
Yes. If output fs doesn't have storage policy support, this job will fail.
And user should not set in the job configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
