guluo2016 commented on code in PR #6709:
URL: https://github.com/apache/hbase/pull/6709#discussion_r2036967657
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##########
@@ -79,6 +80,14 @@ public static void sanityCheck(final Configuration c, final
TableDescriptor td)
// Setting logs to warning instead of throwing exception if sanityChecks
are disabled
boolean logWarn = !shouldSanityCheck(conf);
+ // Check value types
+ warnOrThrowExceptionForFailure(logWarn, () -> ConfigKey.validate(conf));
Review Comment:
In here, we may miss the check for table-level configuration, right?
I think we should check configuration at table level and column level for a
table in here.
eg:
`create 't01', 'info', { CONFIGURATION => {
'hbase.hstore.defaultengine.compactionpolicy.class' => 'com.test.App' }}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
