[ 
https://issues.apache.org/jira/browse/HBASE-29248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942205#comment-17942205
 ] 

Istvan Toth commented on HBASE-29248:
-------------------------------------

Actually, earlier it was incosistent, with the internal ZK server using the 
properties without the ZK prefix, while HBase proper has added the prefix.

The internal ZK server is unlikely to be used in production, so IMO we should 
standardize on the old behaviour for the "normal" client and server components

> HBASE-28529 made an incompatible change to hbase.zookeeper.property handling
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-29248
>                 URL: https://issues.apache.org/jira/browse/HBASE-29248
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> Before HBASE-28529 , HBase took the properties with the 
> _hbase.zookeeper.property._ , removed the _hbase.zookeeper.property._ and 
> added the _zookeeper._ prefix, then set this as a system property.
> When HBASE-28529 has rewritten this to use ZKClientConfig, it forgot to add 
> the _zookeeper._  prefix to the property. ZK uses the exact same names for 
> the ZKClientConfig properties and System properties (where both are supported)
> For example,  to set the _zookeeper.client.secure_ property, earlier we had 
> to set {_}hbase.zookeeper.property.{_}{_}client.secure ,{_} while now we need 
> to set {_}hbase.zookeeper.property.zookeeper.{_}{_}client.secure{_}
> This is an incompatible change, which is likely to cause problems for users 
> that rely on this feature.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to