DieterDP-ng commented on code in PR #6506:
URL: https://github.com/apache/hbase/pull/6506#discussion_r2024347969
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/FullTableBackupClient.java:
##########
@@ -192,6 +198,9 @@ public void execute() throws IOException {
BackupUtils.getMinValue(BackupUtils.getRSLogTimestampMins(newTableSetTimestampMap));
backupManager.writeBackupStartCode(newStartCode);
+ backupManager
+
.deleteBulkLoadedRows(bulkLoadsToDelete.stream().map(BulkLoad::getRowKey).toList());
Review Comment:
Rather than doing batching here, I did it at
`BackupSystemTable.deleteBulkLoadedRows`, since that method is used in multiple
locations, and I guess they would all benefit from batching. See added commit
(can be squashed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
