ndimiduk commented on code in PR #6533:
URL: https://github.com/apache/hbase/pull/6533#discussion_r1971481415


##########
hbase-backup/pom.xml:
##########
@@ -112,6 +112,12 @@
       <scope>test</scope>
     </dependency>
     <!-- General dependencies -->
+    <dependency>
+      <groupId>com.github.stephenc.findbugs</groupId>
+      <artifactId>findbugs-annotations</artifactId>
+      <scope>compile</scope>

Review Comment:
   nit: isn't `compile` the default scope? I think that you can omit this 
attribute. About `optional`, why do you make it so? Should it be considered 
`optional` globally?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to