rmdmattingly commented on code in PR #6651:
URL: https://github.com/apache/hbase/pull/6651#discussion_r1960588481
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:
##########
@@ -270,6 +280,8 @@ protected void loadConf(Configuration conf) {
localityCost = new ServerLocalityCostFunction(conf);
rackLocalityCost = new RackLocalityCostFunction(conf);
+ // Order is important here. We need to construct conditionals to load
candidate generators
+ balancerConditionals.setConf(conf);
Review Comment:
This isn't as great as it can be maybe, but it is much better. Each
StochasticLoadBalancer will build its own BalancerConditionals object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
