hgromer commented on code in PR #6651:
URL: https://github.com/apache/hbase/pull/6651#discussion_r1945219933
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java:
##########
@@ -711,6 +726,44 @@ enum LocalityType {
RACK
}
+ public List<RegionPlan> convertActionToPlans(BalanceAction action) {
Review Comment:
nit: how would you feel about giving the `BalanceAction` a `toRegionsPlans`
method so that we handle everything with inheritance more cleanly, rather than
needing this switch statement? You could have implementations return a
`List<RegionPlan>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
