Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564093375

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 28s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
   |||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  |  master passed  |
   | +1 :green_heart: |  compile  |   3m 33s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 44s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   1m 53s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  branch has no errors when 
running spotless:check.  |
   | -0 :warning: |  patch  |   0m 55s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 19s | 
[/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-mvninstall-root.txt)
 |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 16s | 
[/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt)
 |  hbase-balancer in the patch failed.  |
   | -1 :x: |  compile  |   1m 45s | 
[/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 16s | 
[/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt)
 |  hbase-balancer in the patch failed.  |
   | -0 :warning: |  javac  |   1m 45s | 
[/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m  8s | 
[/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt)
 |  hbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total 
(was 3)  |
   | -1 :x: |  spotbugs  |   0m 34s | 
[/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html)
 |  hbase-balancer generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)  |
   | -1 :x: |  spotbugs  |   0m 33s | 
[/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   | -1 :x: |  hadoopcheck  |   1m  5s |  |  The patch causes 11 errors with 
Hadoop v3.3.6.  |
   | -1 :x: |  hadoopcheck  |   2m 10s |  |  The patch causes 11 errors with 
Hadoop v3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 46s |  |  patch has no errors when 
running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 15s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  20m 46s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | module:hbase-balancer |
   |  |  Return value of addRegions(int[], Set) ignored, but method has no side 
effect  At BalancerClusterState.java:ignored, but method has no side effect  At 
BalancerClusterState.java:[line 785] |
   |  |  Integer is incompatible with expected argument type Class<? extends 
org.apache.hadoop.hbase.master.balancer.CandidateGenerator> in 
org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.getRandomGenerator(BalancerClusterState)
  At FavoredStochasticBalancer.java:argument type Class<? extends 
org.apache.hadoop.hbase.master.balancer.CandidateGenerator> in 
org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.getRandomGenerator(BalancerClusterState)
  At FavoredStochasticBalancer.java:[line 94] |
   |  |  Format string should use %n rather than n in 
org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.lambda$balanceTable$4(Map,
 StringBuilder, Class, Long)  At StochasticLoadBalancer.java:rather than n in 
org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.lambda$balanceTable$4(Map,
 StringBuilder, Class, Long)  At StochasticLoadBalancer.java:[line 631] |
   |  |  
org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.getRandomGenerator(BalancerClusterState)
 makes inefficient use of keySet iterator instead of entrySet iterator  At 
StochasticLoadBalancer.java:keySet iterator instead of entrySet iterator  At 
StochasticLoadBalancer.java:[line 469] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6543 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 25eead892fcc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / ee8c5521c435829869bf20f5692b2f550190f495 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | hadoopcheck | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
 |
   | hadoopcheck | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
 |
   | Max. process+thread count | 85 (vs. ulimit of 30000) |
   | modules | C: hbase-balancer hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/console
 |
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to