Umeshkumar9414 commented on code in PR #6534:
URL: https://github.com/apache/hbase/pull/6534#discussion_r1886431900
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitWALManager.java:
##########
@@ -184,4 +185,19 @@ public void releaseSplitWALWorker(ServerName worker,
MasterProcedureScheduler sc
public void addUsedSplitWALWorker(ServerName worker) {
splitWorkerAssigner.addUsedWorker(worker);
}
+
+ public String renameWALForRetry(String walPath, Integer workerChangeCount)
throws IOException {
+ String originalWALPath;
+ if (workerChangeCount == 0) {
+ originalWALPath = walPath;
+ } else {
+ originalWALPath = walPath.substring(0, walPath.length() -
RETRYING_EXT.length() - 3);
+ }
+ String walNewName =
Review Comment:
No when we have retrying number (workerChangeCount) 0 we don't have any
suffix. This should not cause any trouble in upgrading. As @mnpoonia pointed
out I do need to handle one case when SCP rolled back and second SCP created
another splitwalProcedure in that case the name will contian retrying suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
