chandrasekhar-188k commented on code in PR #6499:
URL: https://github.com/apache/hbase/pull/6499#discussion_r1885547747
##########
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java:
##########
@@ -121,8 +121,10 @@ public class ScannerModel implements
ProtobufMessageHandler, Serializable {
private boolean cacheBlocks = true;
private int limit = -1;
+ @JsonInclude(value = JsonInclude.Include.CUSTOM, valueFilter =
IncludeStartRowFIlter.class)
Review Comment:
> Why do we need the filter for this and not for the stopRow ?
JsonInclude.Include.NON_DEFAULT --> this annotation serialize the attribute
only if the attribute value is different from it's default value , ex: for
boolean variables if the value is false(default) it will not get serialized, if
the value is true it gets serialized.
Since includeStopRow is false by default we can use this annotation, where
as includeStartRow is true by default, so we can't use this annotation because
when the value is set to false this attribute will not get serialized and it
will be giving wrong results in the response of scan request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
