charlesconnell commented on code in PR #6381:
URL: https://github.com/apache/hbase/pull/6381#discussion_r1855462875
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/FileChangeWatcher.java:
##########
@@ -187,21 +188,18 @@ private class WatcherThread extends Thread {
private static final String THREAD_NAME_PREFIX = "FileChangeWatcher-";
- final WatchService watchService;
- final Consumer<WatchEvent<?>> callback;
+ final FileChangeWatcherCallback callback;
- WatcherThread(String threadNameSuffix, WatchService watchService,
- Consumer<WatchEvent<?>> callback) {
+ WatcherThread(String threadNameSuffix, FileChangeWatcherCallback callback)
{
super(THREAD_NAME_PREFIX + threadNameSuffix);
- this.watchService = watchService;
this.callback = callback;
setUncaughtExceptionHandler(FileChangeWatcher::handleException);
}
@Override
public void run() {
try {
- LOG.info("{} thread started", getName());
Review Comment:
This log line and the corresponding "thread finished" one tend to get logged
very frequently and aren't high-value. Lowered priority to DEBUG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
