NihalJain commented on code in PR #6450: URL: https://github.com/apache/hbase/pull/6450#discussion_r1843268332
########## hbase-asyncfs/pom.xml: ########## @@ -194,6 +199,27 @@ <scope>test</scope> </dependency> </dependencies> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-compiler-plugin</artifactId> + <configuration> + <!-- + These files can not compile against hadoop 2.x and we also do not need these + hacks when working with hadoop 2.x, so exclude them here. + See HBASE-28965 for more details + --> + <excludes> + <exclude>**/org/apache/hadoop/hdfs/**</exclude> + </excludes> + <testExcludes> + <testExclude>**/org/apache/hadoop/hbase/io/asyncfs/TestLeaseRenewal**</testExclude> Review Comment: Very nice. I could use this approach to drop #5680 feature to branch-2! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org