hgromer commented on code in PR #6370:
URL: https://github.com/apache/hbase/pull/6370#discussion_r1840963306
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java:
##########
@@ -43,8 +44,13 @@ private BackupRestoreFactory() {
* @return backup restore job instance
*/
public static RestoreJob getRestoreJob(Configuration conf) {
+ Class<? extends RestoreJob> defaultCls =
+ conf.getBoolean(RestoreJob.KEEP_ORIGINAL_SPLITS_OPT, false)
Review Comment:
I'm not sure we have a great mechanism for detecting invalid ancestries.
Region splits are not stored for incremental backups. So we'd have to look
through all the HFiles in the backup, re-generate the splits based on the
files, and then compare them against snapshot manifest.
If we do find an invalid ancestor, what would the expected behavior be? Bear
in mind that we would be reviewing for incompatible ancestors during the
restore process, so any additional processing + exceptions thrown would occur
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
