anmolnar commented on code in PR #6447:
URL: https://github.com/apache/hbase/pull/6447#discussion_r1837073713
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:
##########
@@ -324,6 +330,13 @@ public void onConfigurationChange(Configuration newConf) {
refreshAuthManager(newConf, new HBasePolicyProvider());
}
refreshSlowLogConfiguration(newConf);
+ if (
+ CoprocessorConfigurationUtil.checkConfigurationChange(getConf(), newConf,
+ CoprocessorHost.RPC_COPROCESSOR_CONF_KEY)
+ ) {
+ LOG.info("Update the RPC coprocessor(s) because the configuration has
changed");
+ initializeCoprocessorHost(newConf);
Review Comment:
Strictly for this particular hook we don't anything else. Configuration
object is needed to instantiate Observers, the rest is passed in method
arguments.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java:
##########
@@ -324,6 +330,13 @@ public void onConfigurationChange(Configuration newConf) {
refreshAuthManager(newConf, new HBasePolicyProvider());
}
refreshSlowLogConfiguration(newConf);
+ if (
+ CoprocessorConfigurationUtil.checkConfigurationChange(getConf(), newConf,
+ CoprocessorHost.RPC_COPROCESSOR_CONF_KEY)
+ ) {
+ LOG.info("Update the RPC coprocessor(s) because the configuration has
changed");
+ initializeCoprocessorHost(newConf);
Review Comment:
Strictly for this particular hook we don't need anything else. Configuration
object is needed to instantiate Observers, the rest is passed in method
arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
