stoty commented on code in PR #6453:
URL: https://github.com/apache/hbase/pull/6453#discussion_r1835997417
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:
##########
@@ -640,8 +639,9 @@ public static boolean shouldRetryCreate(RemoteException e) {
static void completeFile(FanOutOneBlockAsyncDFSOutput output, DFSClient
client,
ClientProtocol namenode, String src, String clientName, ExtendedBlock
block,
- HdfsFileStatus stat) {
- for (int retry = 0;; retry++) {
+ HdfsFileStatus stat) throws IOException {
+ int maxRetries =
client.getConf().getBlockWriteLocateFollowingInitialDelayMs();
Review Comment:
The method name refers to milliseconds, which makes this sound we're using a
temporal value for the number of retries.
Is this really the config option we want here ? Is the Hadoop getter
misnamed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
