Duo Zhang created HBASE-28972: --------------------------------- Summary: Limit the number of retries in FanOutOneBlockAsyncDFSOutputHelper.completeFile Key: HBASE-28972 URL: https://issues.apache.org/jira/browse/HBASE-28972 Project: HBase Issue Type: Improvement Reporter: Duo Zhang
After HBASE-28955, when shutting down MiniDFSCluster, we will close all the output streams. And in some WAL related tests, we want to keep the WAL file as open so we set namenode to safe mode before shutting down, like TestWALFactory.testAppendClose. And in FanOutOneBlockAsyncDFSOutputHelper.completeFile, we will only give up when hitting LeaseExpireException, so in this scenario, we will block there forever... In general, if there is an error while complete file, we could go with the recoverLease logic so it is OK to throw exception when completeFile. We should change the implementation so it does not block there forever. -- This message was sent by Atlassian Jira (v8.20.10#820010)