hgromer commented on code in PR #6370:
URL: https://github.com/apache/hbase/pull/6370#discussion_r1827822786
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -437,6 +445,29 @@ protected void walToHFiles(List<String> dirPaths,
List<String> tableList) throws
}
}
+ private void incrementalCopyBulkloadHFiles(FileSystem tgtFs, TableName tn)
throws IOException {
+ Path bulkOutDir = getBulkOutputDirForTable(tn);
+ FileSystem fs = FileSystem.get(conf);
+
+ if (fs.exists(bulkOutDir)) {
Review Comment:
the bulk output dir doesn't exist if there were no bulkloaded files that we
need to re-split. I agree that the check doesn't do a good job of informing you
as to why the output directory might exist. I'm happy to do the following
1. Add a boolean flag to track if there are files that we've bulkloaded +
re-split
2. Add a comment here to explain why this check is necessary
A comment here might be easiest, as it doesn't require additional logic in
the code itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
