stoty commented on code in PR #6361:
URL: https://github.com/apache/hbase/pull/6361#discussion_r1820297090
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java:
##########
@@ -142,6 +155,31 @@ boolean areSerializedFieldsEqual(Filter o) {
return Bytes.equals(this.getPrefix(), other.getPrefix());
}
+ @Override
+ public Cell getNextCellHint(Cell cell) {
+ byte[] hintBytes;
+ if (reversed) {
+ // On reversed scan hint should be the prefix with last byte incremented
+ hintBytes = increaseLastNonMaxByte(this.prefix);
Review Comment:
I thought about this some more:
At least one case when the HINT is not honored is FilterListWithOR , which
will use the closest HINT provided by any of the filters, so if another filter
returns a hint that is closer than the one PrefixFilter provides, it is going
to be evaluated, possibly a lot of times.
Pre-computing the hint is definitely the most optimal solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
