NihalJain opened a new pull request, #6382:
URL: https://github.com/apache/hbase/pull/6382

   Reverts apache/hbase#6368
   
   I see some test failures during debugging some other code. Apparently we use 
hbase-webapps folder to create an instance hbase local cluster and the folder 
needs to be present in classpath. I am seeing following since we have removed 
hbase-webapps from hbase-server jar
   
   ```
   Caused by: java.io.FileNotFoundException: hbase-webapps/master not found in 
CLASSPATH
           at 
org.apache.hadoop.hbase.http.HttpServer.getWebAppsPath(HttpServer.java:1086)
           at 
org.apache.hadoop.hbase.http.HttpServer.getWebAppsPath(HttpServer.java:1073)
           at 
org.apache.hadoop.hbase.http.HttpServer.<init>(HttpServer.java:589)
           at 
org.apache.hadoop.hbase.http.HttpServer$Builder.build(HttpServer.java:431)
           at org.apache.hadoop.hbase.http.InfoServer.<init>(InfoServer.java:92)
           at 
org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:345)
           at 
org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307)
           at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:511)
           at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
 Method)
           at 
java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
           at 
java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
           at 
java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
           at 
java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
           at 
org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124)
           ... 40 more
   ```
   
   Fix is to include hbase-webapps in classpath for each impacted module. 
Reverting this for now to unblock any new PRs which may get impacted due to 
this change. Will raise another PR to handle the above case along with current 
change.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to