2005hithlj commented on code in PR #6347:
URL: https://github.com/apache/hbase/pull/6347#discussion_r1804764378


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java:
##########
@@ -278,6 +278,19 @@ public Map<byte[], List<Path>> run() {
               if (!fs.exists(stageFamily)) {
                 fs.mkdirs(stageFamily);
                 fs.setPermission(stageFamily, PERM_ALL_ACCESS);
+                if (
+                  
conf.getBoolean(HConstants.BULKLOAD_COPYFILE_STORAGE_POLICY_ENABLED_KEY,
+                    
HConstants.BULKLOAD_COPYFILE_STORAGE_POLICY_ENABLED_DEFAULT)
+                    && (!FSUtils.isSameHdfs(conf, new 
Path(el.getSecond()).getFileSystem(conf), fs)

Review Comment:
   I'm sorry, my description did indeed omit the second scenario, for the 
second scenario (Within the same HDFS bulkload but copyfile), if the tiered 
storage policy is not configured when generating the HFile during the first 
phase of the bulkload, it can still achieve the purpose of tiered storage in 
the second phase by specifying -Dalways.copy.files=true, this scenario provides 
users with an additional  opportunity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to