stoty commented on code in PR #6361:
URL: https://github.com/apache/hbase/pull/6361#discussion_r1801503020
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java:
##########
@@ -50,10 +52,16 @@ public byte[] getPrefix() {
@Override
public boolean filterRowKey(Cell firstRowCell) {
- if (firstRowCell == null || this.prefix == null) return true;
- if (filterAllRemaining()) return true;
+ if (firstRowCell == null || this.prefix == null) {
+ return true;
+ }
+ if (filterAllRemaining()) {
+ return true;
+ }
int length = firstRowCell.getRowLength();
- if (length < prefix.length) return true;
Review Comment:
Actually this if looks buggy.
If the firstRowCell is lexicographically smaller than the prefix, then we
still want to provide the hint, regardless of the key length.
We can probably just drop this, I believe that the compare later will also
handle this case.
This was supposed to be an optization, but it is not relevant when we
provide hints, and in fact hurts performance.
Please fix and also add test cases for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
