PDavid commented on code in PR #6361:
URL: https://github.com/apache/hbase/pull/6361#discussion_r1795586362
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java:
##########
@@ -50,10 +52,16 @@ public byte[] getPrefix() {
@Override
public boolean filterRowKey(Cell firstRowCell) {
- if (firstRowCell == null || this.prefix == null) return true;
- if (filterAllRemaining()) return true;
+ if (firstRowCell == null || this.prefix == null) {
+ return true;
+ }
+ if (filterAllRemaining()) {
+ return true;
+ }
int length = firstRowCell.getRowLength();
- if (length < prefix.length) return true;
Review Comment:
These are actually not strictly required to resolve the ticket. Just the
checkstyle report contained these warnings:
```
(blocks) NeedBraces: 'if' construct must use '{}'s.
(blocks) NeedBraces: 'if' construct must use '{}'s.
(blocks) NeedBraces: 'if' construct must use '{}'s.
(blocks) NeedBraces: 'if' construct must use '{}'s.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
