stoty commented on code in PR #132: URL: https://github.com/apache/hbase-connectors/pull/132#discussion_r1793476617
########## pom.xml: ########## @@ -933,6 +973,40 @@ </plugins> </build> </profile> + <profile> + <id>build-with-jdk8</id> + <activation> + <jdk>1.8</jdk> + </activation> + <properties> + <maven.compiler.source>${compileSource}</maven.compiler.source> + <maven.compiler.target>${compileSource}</maven.compiler.target> + </properties> + </profile> + <profile> + <id>build-with-jdk11</id> Review Comment: Wouldn't it be better to have exclusive profiles ? We could see all settings in one place then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org