hgromer commented on code in PR #6345:
URL: https://github.com/apache/hbase/pull/6345#discussion_r1792397482
##########
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackup.java:
##########
@@ -224,7 +241,92 @@ public void TestIncBackupRestore() throws Exception {
hTable = conn.getTable(table2_restore);
Assert.assertEquals(NB_ROWS_IN_BATCH + 5,
HBaseTestingUtil.countRows(hTable));
hTable.close();
+
+ // Test bulkloads
+ newTable1Desc = TableDescriptorBuilder.newBuilder(newTable1Desc)
+ .setColumnFamily(ColumnFamilyDescriptorBuilder.of(fam3Name)).build();
+ updateDesc(newTable1Desc, tables, conn);
+ testBulkloads(conn, famName, mobName);
Review Comment:
Maybe I'll split up the tests in that case. I just want to test that
bulkloaded files actually are restored to the table correctly. So I can have a
bulkload-specific test that
1. Bulkloads data + writes data
2. Takes a full backup
3. Verifies all the data exists
4. Bulkloads more data
5. Takes incremental backup
6. Verifies data exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
