[ https://issues.apache.org/jira/browse/HBASE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885536#comment-17885536 ]
Duo Zhang commented on HBASE-17852: ----------------------------------- While audit the issues for 3.0.0 release, I found that there is no commit with HBASE-17852 in our code but the fix version for this issue has 3.0.0-alpha-1. But I can see this commit {noformat} commit a5601c8eac6bfcac7d869574547f505d44e49065 Author: Vladimir Rodionov <vrodio...@hortonworks.com> Date: Wed Jan 10 16:26:09 2018 -0800 HBASE-19568: Restore of HBase table using incremental backup doesn't restore rows from an earlier incremental backup Signed-off-by: Josh Elser <els...@apache.org> {noformat} So I guess we used the wrong commit message or something? Anyway, since these two issues seem to want to fix the same problem, include either one in the release note is enough? So I plan to remove the fix version here. Shout if there are any problems. Thanks. > Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental > backup) > ------------------------------------------------------------------------------------ > > Key: HBASE-17852 > URL: https://issues.apache.org/jira/browse/HBASE-17852 > Project: HBase > Issue Type: Sub-task > Reporter: Vladimir Rodionov > Assignee: Vladimir Rodionov > Priority: Major > Fix For: 3.0.0-alpha-1 > > Attachments: HBASE-17852-v10.patch, screenshot-1.png > > > Design approach rollback-via-snapshot implemented in this ticket: > # Before backup create/delete/merge starts we take a snapshot of the backup > meta-table (backup system table). This procedure is lightweight because meta > table is small, usually should fit a single region. > # When operation fails on a server side, we handle this failure by cleaning > up partial data in backup destination, followed by restoring backup > meta-table from a snapshot. > # When operation fails on a client side (abnormal termination, for example), > next time user will try create/merge/delete he(she) will see error message, > that system is in inconsistent state and repair is required, he(she) will > need to run backup repair tool. > # To avoid multiple writers to the backup system table (backup client and > BackupObserver's) we introduce small table ONLY to keep listing of bulk > loaded files. All backup observers will work only with this new tables. The > reason: in case of a failure during backup create/delete/merge/restore, when > system performs automatic rollback, some data written by backup observers > during failed operation may be lost. This is what we try to avoid. > # Second table keeps only bulk load related references. We do not care about > consistency of this table, because bulk load is idempotent operation and can > be repeated after failure. Partially written data in second table does not > affect on BackupHFileCleaner plugin, because this data (list of bulk loaded > files) correspond to a files which have not been loaded yet successfully and, > hence - are not visible to the system -- This message was sent by Atlassian Jira (v8.20.10#820010)