NihalJain commented on code in PR #6295:
URL: https://github.com/apache/hbase/pull/6295#discussion_r1775539470


##########
pom.xml:
##########
@@ -931,7 +931,7 @@
         databind] must be kept in sync with the version of 
jackson-jaxrs-json-provider shipped in
         hbase-thirdparty.
     -->
-    <hbase-thirdparty.version>4.1.8</hbase-thirdparty.version>
+    <hbase-thirdparty.version>4.1.9</hbase-thirdparty.version>

Review Comment:
   > And on netty4 dependencies, hbase does not depend on it directly since we 
use the shaded one in hbase thirdparty, it is mainly introduced by hadoop and 
zookeeper. And in hadoop 3.4.0, IIRC hadoop also shaded and relocated netty in 
their thirdparty jar, so maybe we need to discuss whether we will need to force 
netty dependencies in hbase, maybe just leave it as is.
   
   So we need not necessarily align netty with thirdparty.
   Same for error prone.
   
   > Filed https://issues.apache.org/jira/browse/HBASE-28883
   
   Please see https://github.com/apache/hbase-thirdparty/pull/124, 
https://github.com/NihalJain/hbase/commit/0b51c7161d6b891a703546d8ec90a64cb2d8535b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to